Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include MirrorDaemonCount in the ConfigMap API #4577

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

nixpanic
Copy link
Member

It seems that original commit 4c2d2ca modified the API under the
vendor/ directory. Weirdly this did not cause any issues?! The change
should have been done in the api/deploy/kubernetes/ file instead, that
gets sync'd after running "go mod vendor".

@nixpanic nixpanic added the bug Something isn't working label Apr 23, 2024
@nixpanic nixpanic requested review from Madhu-1 and a team April 23, 2024 11:21
@mergify mergify bot added the component/build Issues and PRs related to compiling Ceph-CSI label Apr 23, 2024
@nixpanic nixpanic added the ci/skip/e2e skip running e2e CI jobs label Apr 23, 2024
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 24, 2024

@Mergifyio queue

Copy link
Contributor

mergify bot commented Apr 24, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4b49d28

It seems that original commit 4c2d2ca modified the API under the
vendor/ directory. Weirdly this did not cause any issues?! The change
should have been done in the api/deploy/kubernetes/ file instead, that
gets sync'd after running "go mod vendor".

Signed-off-by: Niels de Vos <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Apr 24, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 24, 2024
@mergify mergify bot merged commit 4b49d28 into ceph:devel Apr 24, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/skip/e2e skip running e2e CI jobs component/build Issues and PRs related to compiling Ceph-CSI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants